[PATCH] D14654: Use a different block id for block of metadata kind records

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:409
@@ -408,1 +408,3 @@
+  std::error_code parseMetadataKinds();
+  std::error_code parseMetadataKindRecord(SmallVector<uint64_t, 64> &Record);
   std::error_code parseMetadataAttachment(Function &F);
----------------
joker.eph wrote:
> Usually function parameters are `SmallVectorImpl`
Will fix.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:2409
@@ +2408,3 @@
+    default: // Default behavior: ignore.
+      break;
+    case bitc::METADATA_KIND: {
----------------
joker.eph wrote:
> What kind of record is allowed here that we want to ignore?
This is consistent with all the other parsing routines that ignore unrecognized blocks and records. 


http://reviews.llvm.org/D14654