[PATCH] D14300: MSP430 calling convention updates

Anton Korobeynikov via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 14 11:52:30 PST 2015


asl accepted this revision.
asl added a comment.
This revision is now accepted and ready to land.

Ok to commit with these 2 small changes. Thanks!


================
Comment at: lib/Target/MSP430/MSP430ISelLowering.cpp:327
@@ +326,3 @@
+    // Only 32-bit arguments may be split between R15 and the stack, and
+    // only if no arguments have been placed on the stack yet.
+    if ((PartsLeft != 0) &&
----------------
Add comment about backfilling here as well.

================
Comment at: lib/Target/MSP430/MSP430ISelLowering.cpp:337
@@ +336,3 @@
+    // Assign arguments to stack.
+    if (PartsLeft != 0){
+      StackUsed = true;
----------------
Minor nit: space after )


http://reviews.llvm.org/D14300





More information about the llvm-commits mailing list