[PATCH] D14174: [mips][microMIPS] Implement EXTP, EXTPDP, EXTPDPV, EXTPV, EXTR[_RS].W, EXTR_S.H, EXTRV[_RS].W and EXTRV_S.H instructions

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a formatting nit.

I didn't double check all the implicit-uses and implicit-defs since I have a lot of reviews to catch up on but the first few looked good.


================
Comment at: lib/Target/Mips/MicroMipsDSPInstrInfo.td:133-146
@@ -120,1 +132,16 @@
 
+class EXT_MM_2R_DESC_BASE<string instr_asm, SDPatternOperator OpNode,
+                          InstrItinClass itin> {
+  dag OutOperandList = (outs GPR32Opnd : $rt);
+  dag InOperandList = (ins ACC64DSPOpnd : $ac, GPR32Opnd : $rs);
+  string AsmString = !strconcat(instr_asm, "\t$rt, $ac, $rs");
+  InstrItinClass Itinerary = itin;
+}
+class EXT_MM_1R_DESC_BASE<string instr_asm, SDPatternOperator OpNode,
+                          InstrItinClass itin> {
+  dag OutOperandList = (outs GPR32Opnd : $rt);
+  dag InOperandList = (ins ACC64DSPOpnd : $ac, uimm5 : $imm);
+  string AsmString = !strconcat(instr_asm, "\t$rt, $ac, $imm");
+  InstrItinClass Itinerary = itin;
+}
+
----------------
Formatting nit: 'GPR32Opnd : $rt' -> 'GPR32Opnd:$rt' and similar.


http://reviews.llvm.org/D14174