[PATCH] D14058: [mips][microMIPS] Implement DPS.W.PH, DPSQ_S.W.PH, DPSQ_SA.L.W, DPSQX_S.W.PH, DPSQX_SA.W.PH, DPSU.H.QBL, DPSU.H.QBR and DPSX.W.PH instructions

[Daniel Sanders via llvm-commits]

dsanders accepted this revision.
dsanders added a comment.
This revision is now accepted and ready to land.

LGTM with a small tweak to the tests.

By the way, I recently discovered that we have no DSPr1 tests for the standard encodings. Given that you are adding tests for microMIPS DSPr1, would you be willing to add standard encoding tests too?


================
Comment at: test/MC/Disassembler/Mips/micromips-dspr2/valid.txt:18-21
@@ -17,1 +17,5 @@
 0x00 0x64 0xb1 0xfc # CHECK: shra_r.qb $3, $4, 5
+0x00 0xc4 0x44 0xbc # CHECK: dps.w.ph $ac1, $4, $6
+0x00 0xc4 0x66 0xbc # CHECK: dpsqx_s.w.ph $ac1, $4, $6
+0x00 0xc4 0x76 0xbc # CHECK: dpsqx_sa.w.ph $ac1, $4, $6
+0x00 0xc4 0x54 0xbc # CHECK: dpsx.w.ph $ac1, $4, $6
----------------
The DSPr2 test file should also contain DSPr1 tests. The intent is that you can diff the two files and the differences are just the instructions that were added in DSPr2. It also serves as a check that the predicates are correct.

Likewise for the assembler tests.


http://reviews.llvm.org/D14058