[lld] r252978 - ELF2: Add comments and reorganize option list a bit.

[Sean Silva via llvm-commits]

Thanks.

On Fri, Nov 13, 2015 at 10:58 AM, Rui Ueyama <ruiu at google.com> wrote:

> r253058
>
> On Thu, Nov 12, 2015 at 6:42 PM, Sean Silva <chisophugis at gmail.com> wrote:
>
>>
>>
>> On Thu, Nov 12, 2015 at 4:26 PM, Rui Ueyama via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: ruiu
>>> Date: Thu Nov 12 18:26:12 2015
>>> New Revision: 252978
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=252978&view=rev
>>> Log:
>>> ELF2: Add comments and reorganize option list a bit.
>>>
>>> Modified:
>>>     lld/trunk/ELF/Options.td
>>>
>>> Modified: lld/trunk/ELF/Options.td
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=252978&r1=252977&r2=252978&view=diff
>>>
>>> ==============================================================================
>>> --- lld/trunk/ELF/Options.td (original)
>>> +++ lld/trunk/ELF/Options.td Thu Nov 12 18:26:12 2015
>>> @@ -133,17 +133,21 @@ def alias_script_T : Separate<["-"], "T"
>>>  def alias_strip_all: Flag<["-"], "s">, Alias<strip_all>;
>>>  def alias_undefined_u : Separate<["-"], "u">, Alias<undefined>;
>>>
>>> -// Options listed below are silently ignored now.
>>> -def build_id : Flag<["--"], "build-id">;
>>> -def eh_frame_hdr : Flag<["--"], "eh-frame-hdr">;
>>> +// Our symbol resolution algorithm handles symbols in archive files
>>> better
>>> +// than traditional linkers, so we don't need --start-group and
>>> --end-group.
>>>
>>
>> Can we just say "differently"?
>>
>> -- Sean Silva
>>
>>
>>> +// These options are recongized but ignored for compatibility.
>>>  def end_group : Flag<["--"], "end-group">;
>>>  def end_group_paren: Flag<["-"], ")">;
>>> +def start_group : Flag<["--"], "start-group">;
>>> +def start_group_paren: Flag<["-"], "(">;
>>> +
>>> +// Options listed below are silently ignored for now for compatibility.
>>> +def build_id : Flag<["--"], "build-id">;
>>> +def eh_frame_hdr : Flag<["--"], "eh-frame-hdr">;
>>>  def fatal_warnings : Flag<["--"], "fatal-warnings">;
>>>  def no_add_needed : Flag<["--"], "no-add-needed">;
>>>  def no_fatal_warnings : Flag<["--"], "no-fatal-warnings">;
>>>  def no_warn_mismatch : Flag<["--"], "no-warn-mismatch">;
>>> -def start_group : Flag<["--"], "start-group">;
>>> -def start_group_paren: Flag<["-"], "(">;
>>>  def version_script : Separate<["--"], "version-script">;
>>>  def warn_common : Flag<["--"], "warn-common">;
>>>  def warn_shared_textrel : Flag<["--"], "warn-shared-textrel">;
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151113/cbda8d37/attachment.html>