[PATCH] D14296: [LV][LAA] Add a layer over SCEV to apply run-time checked knowledge on SCEV expressions

[Adam Nemet via llvm-commits]

anemet added a comment.

In http://reviews.llvm.org/D14296#288671, @sbaranga wrote:

> LLE is not broken, but introducing some new SCEV predicates might break it.
>
> There are some places where it should do PSE->getSCEV(Value) instead of SE->getValue().  To be more specific, in isDependenceDistanceOfOne we assume that pointers from a forward/backward dependence are AddRecExprs when we query SCEV directly. However, with predicates, they might not be. I expect this might trigger an assert in some cases after we introduce predicates for overflows. So before introducing the new predicates, we have to change LLE to use PSE there.


OK, that makes sense.


http://reviews.llvm.org/D14296