[PATCH] D14656: [sanitizer] Stop unwinding the stack when a close-to-zero PC is found

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 12:33:51 PST 2015


kubabrecka added a comment.

In http://reviews.llvm.org/D14656#289133, @samsonov wrote:

> This doesn't look like a good change. Why is this fixed only in fast, but not in slow unwinder? Are you sure we should consider any address 0x1000 as bad, not only 0x0?


Ignoring `0x0` is not enough.  The result `0x0` printed in the stack trace is actually a `0x1` at the bottom of the stack (because we subtract 1 from return addresses in `GetPreviousInstructionPc`).


http://reviews.llvm.org/D14656





More information about the llvm-commits mailing list