[PATCH] D14468: Add zero size dummy data to ensure section symbol is always created

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 12:29:37 PST 2015


davidxl marked 4 inline comments as done.

================
Comment at: test/profile/instrprof-shared.test:30
@@ +29,3 @@
+RUN: llvm-profdata merge -o %t-no-instr2-instr.profdata %t-no-instr2-instr.profraw
+
+RUN: llvm-profdata show -counts --function main %t-instr-instr.profdata | grep -v 'Total\|Maximum' > %t-main-1
----------------
vsk wrote:
> Can you add negative tests (`not RUN`?) showing that the uninstrumented binaries produce no profraw files?
I have added two. There are two cases no-instr*-no-instr2 where linux version produces zero size prof data vs non-existing file (making changes to unlink file can be tricky) -- so adding a test here can be tricky. As this is not the expected using case anyway, existing testings already cover the expected behavior (build, run etc), I will leave this as it is .


http://reviews.llvm.org/D14468





More information about the llvm-commits mailing list