[PATCH] D14621: [ELF2] - Implemented R_X86_64_GOTTPOFF relocation

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 13 06:39:10 PST 2015


rafael accepted this revision.
rafael added a comment.

LGTM with a nit.


================
Comment at: ELF/InputSection.cpp:143
@@ -142,3 +142,3 @@
       SymVA = Out<ELFT>::Got->getEntryAddr(Body);
-      Type = Target->getGotRefReloc();
+      Type = Body.isTLS() ? Target->getTlsGotReloc() : Target->getGotRefReloc();
     } else if (Target->relocPointsToGot(Type)) {
----------------
Maybe just pass body to getGotReloc?


http://reviews.llvm.org/D14621





More information about the llvm-commits mailing list