[PATCH] D14148: [GlobalOpt] Demote globals to locals more aggressively

[James Molloy via llvm-commits]

jmolloy updated this revision to Diff 40137.
jmolloy added a comment.

Hi Mehdi, Duncan, Manman,

I've updated the patch following all your comments. Implementing Mehdi's suggestion made the code look significantly neater and will also catch more cases.

I've also undone the reordering of optimizations in ProcessInternalGlobal, as I don't think this is now needed now that "main" isn't implicitly norecurse. It was only done to pacify tests in the first place, and they all pass now without modification.

Cheers,

James


Repository:
  rL LLVM

http://reviews.llvm.org/D14148

Files:
  lib/Transforms/IPO/GlobalOpt.cpp
  test/Transforms/GlobalOpt/global-demotion.ll
  test/Transforms/GlobalOpt/metadata.ll
  test/Transforms/MergeFunc/crash2.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14148.40137.patch
Type: text/x-patch
Size: 8760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151113/e5691919/attachment.bin>