[PATCH] D14632: [MachineSink] Don't break ImplicitNulls

[Sanjoy Das via llvm-commits]

sanjoy added a comment.

I added a comment to the `ImplicitNullChecks` pass stating why it is difficult to work with loads sunk below control flow:  http://reviews.llvm.org/rL253020


================
Comment at: lib/CodeGen/MachineSink.cpp:684
@@ +683,3 @@
+/// guarantee MI cannot possibly be used to do a null check.
+static bool IsLikelyImplicitNullCheck(MachineInstr *MI,
+                                      const TargetInstrInfo *TII,
----------------
Reading this on phabricator makes me feel that the naming here is not great -- I'll rename this function to `SinkingPreventsImplicitNullCheck` tomorrow.


http://reviews.llvm.org/D14632