[PATCH] D14586: [elf2] Implement global dynamic tls.

[Michael Spencer via llvm-commits]

Bigcheese added inline comments.

================
Comment at: ELF/InputSection.cpp:129
@@ +128,3 @@
+
+    if (Type == Target->getTlsGlobalDynamicReloc()) {
+      Target->relocateOne(BufLoc, BufEnd, Type, AddrLoc,
----------------
ruiu wrote:
> You are not using a return value of getTlsGlobalDynamicReloc except comparing it with Type. Isn't isTlsGlobalDynamicReloc(uint32_t) better than getTlsGlobalDynamicReloc()?
Probably. We would need to change getTlsLocalDynamicReloc too.


http://reviews.llvm.org/D14586