[PATCH] D14613: [tsan] Add global symbolication support into DlAddrSymbolizer

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 07:37:33 PST 2015


kubabrecka added inline comments.

================
Comment at: test/tsan/Darwin/symbolizer-dladdr.cc:2
@@ +1,3 @@
+// RUN: %clangxx_tsan %s -o %t
+// RUN: TSAN_OPTIONS=$TSAN_OPTIONS:verbosity=2:external_symbolizer_path= %deflake %run %t | FileCheck %s
+#include "../test.h"
----------------
glider wrote:
> Do we also want an ASan test for this functionality?
We have some dladdr tests in dladdr-demangling.cc, sandbox-symbolizer.cc and suppressions-sandbox.cc.  Or did you mean to specifically add a test for symbolication of globals?


Repository:
  rL LLVM

http://reviews.llvm.org/D14613





More information about the llvm-commits mailing list