[PATCH] D14571: [ELF2] - Implemented PT_GNU_STACK support

[George Rimar via llvm-commits]

>Date: Thu, 12 Nov 2015 13:58:49 +0100
>From: Joerg Sonnenberger via llvm-commits
>        <llvm-commits at lists.llvm.org>
>To: llvm-commits at lists.llvm.org
>Subject: Re: [PATCH] D14571: [ELF2] - Implemented PT_GNU_STACK support
>Message-ID: <20151112125849.GA21689 at britannica.bec.de>
>Content-Type: text/plain; charset=us-ascii
>
>On Wed, Nov 11, 2015 at 02:13:58PM +0000, George Rimar via llvm-commits wrote:
>> Index: test/elf2/gnustack.s
>> ===================================================================
>> --- test/elf2/gnustack.s
>> +++ test/elf2/gnustack.s
>> @@ -0,0 +1,125 @@
>> +# REQUIRES: x86
>> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/gnustack2.s -o %t3
>> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1
>> +# RUN: ld.lld2 %t1 %t3 -o %t
>> +# RUN: llvm-readobj --program-headers -s %t | FileCheck --check-prefix=CHECK_RW %s
>> +# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/gnustack.s -o %t2
>> +# RUN: ld.lld2 %t1 %t2 %t3 -o %t
>> +# RUN: llvm-readobj --program-headers %t | FileCheck --check-prefix=CHECK_RWX %s
>> +# RUN: ld.lld2 %t1 -o %t
>> +# RUN: llvm-readobj --program-headers %t | FileCheck --check-prefix=CHECK_NOGNUSTACK %s
>
>Can you rename the additional inputs please to reflect the content
>(gnustack-x.s and gnustack-nx.s?) and use %t1 for the output of %s? That
>was a bit difficult to read :)
>
>Joerg

Sure thing :) I guess you mean "%t1 for the output of %p/Inputs/gnustack2.s" because %t1 is already used for %s. 
I`ll change the names of temps to make it more clear.

Best regards,
George.