[PATCH] D14613: [tsan] Add global symbolication support into DlAddrSymbolizer

[Alexander Potapenko via llvm-commits]

glider accepted this revision.
glider added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: test/tsan/Darwin/symbolizer-dladdr.cc:2
@@ +1,3 @@
+// RUN: %clangxx_tsan %s -o %t
+// RUN: TSAN_OPTIONS=$TSAN_OPTIONS:verbosity=2:external_symbolizer_path= %deflake %run %t | FileCheck %s
+#include "../test.h"
----------------
Do we also want an ASan test for this functionality?

================
Comment at: test/tsan/Darwin/symbolizer-dladdr.cc:21
@@ +20,3 @@
+  GlobalData[2] = 43;
+  barrier_wait(&barrier);
+  pthread_join(t, 0);
----------------
dvyukov: do we want to rename barrier_wait() to e.g. invisible_barrier_wait() or smth. else that indicates TSan doesn't know about this barrier?


http://reviews.llvm.org/D14613