[PATCH] D13659: Implement .reloc (constant offset only) with support for R_MIPS_NONE and R_MIPS_32.

[Daniel Sanders via llvm-commits]

dsanders added a comment.

I committed this in r252888 since I have an LGTM from David and there have been no further comments in the last two weeks.


================
Comment at: lib/MC/MCObjectStreamer.cpp:446
@@ +445,3 @@
+  MCFixupKind Kind;
+  if (Assembler->getBackend().getFixupKind(Name, Kind)) {
+    if (Expr == nullptr)
----------------
majnemer wrote:
> You could reduce indentation by returning `true` if `getFixupKind` fails.
I made this change in the commit.


Repository:
  rL LLVM

http://reviews.llvm.org/D13659