[PATCH] D14338: [DebugInfo] Fix ARM/AArch64/Mips/Sparc/SystemZ/X86 prologue_end position. Related to D11268.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 02:17:16 PST 2015


dsanders added a comment.

In http://reviews.llvm.org/D14338#287340, @iid_iunknown wrote:

> In http://reviews.llvm.org/D14338#287129, @dsanders wrote:
>
> > I agree with the Mips16 changes but could you be a bit clearer with the subject line when the patch isn't ARM/AArch64 specific? I skipped over the http://reviews.llvm.org/D11268 thread because the subject line said it was ARM-only :-). Herald now CC's me on patches that touch the Mips directories so it doesn't matter as much anymore but a clearer subject line would still be useful.
>
>
> Hi Daniel,
>
> My apologies for that. I will be more specific in future review requests.
>  Thanks for pointing this out!


No worries. Thanks for updating the title.


Repository:
  rL LLVM

http://reviews.llvm.org/D14338





More information about the llvm-commits mailing list