[PATCH] D14571: [ELF2] - Implemented PT_GNU_STACK support

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 12 00:50:51 PST 2015


grimar added a comment.

In http://reviews.llvm.org/D14571#287432, @ruiu wrote:

> Is the logic implemented in this patch correct?
>
> The stack is executable if and only if all object files contain .note.GNU-stack section. The logic implemented in this patch seems to make the stack executable at least one of input files contains .note.GNU-stack section.


Below is the link to gold source comment about how stack stuff works.
https://android.googlesource.com/toolchain/binutils/+/53b6ed3bceea971857c996b6dcb96de96b99335f/binutils-2.19/gold/layout.cc#1942


http://reviews.llvm.org/D14571





More information about the llvm-commits mailing list