[PATCH] D14577: Cull non-standard variants of ARM architectures (NFC)

[Renato Golin via llvm-commits]

rengolin added a comment.

So, you removed the CPU names, but not the arch names. Try removing the AK_* types from the CPUs that you remove and see if anything breaks...


================
Comment at: include/llvm/Support/ARMTargetParser.def:183
@@ -182,3 +168,1 @@
-ARM_CPU_NAME("iwmmxt", AK_ARMV5TE, FK_NONE, false, AEK_NONE)
-ARM_CPU_NAME("xscale", AK_ARMV5TE, FK_NONE, false, AEK_NONE)
 ARM_CPU_NAME("arm926ej-s", AK_ARMV5TEJ, FK_NONE, true, AEK_NONE)
----------------
Did you look through all the options that use AK_ARMV5TE or AK_XSCALE? Are they always being treated in the same way every time?

================
Comment at: include/llvm/Support/ARMTargetParser.def:233
@@ -232,3 @@
-ARM_CPU_NAME("cortex-m0", AK_ARMV6SM, FK_NONE, true, AEK_NONE)
-ARM_CPU_NAME("arm1176jzf-s", AK_ARMV6HL, FK_VFPV2, true, AEK_NONE)
-ARM_CPU_NAME("cortex-a8", AK_ARMV7, FK_NEON, true, AEK_SEC)
----------------
This CPU name was an old one that was added for some reason I don't remember... :( some GCC compatibility, I guess. IIRC, this was well before we created the TargetParser.

================
Comment at: lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp:704
@@ -703,3 +703,2 @@
   case ARM::AK_ARMV4:
-  case ARM::AK_ARMV5:
     setAttributeItem(ARM_ISA_use, Allowed, false);
----------------
I guess there isn't a v5 without Thumb...


http://reviews.llvm.org/D14577