[PATCH] D14140: [ELF2] SECTIONS command basic support

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 11 13:59:43 PST 2015


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/Writer.cpp:40
@@ +39,3 @@
+  Writer(SymbolTable<ELFT> &S) : Symtab(S) {
+    buildSectionMap();
+  }
----------------
Please move this to the beginning of Writer<ELFT>::run().


http://reviews.llvm.org/D14140





More information about the llvm-commits mailing list