[polly] r252713 - ScopInfo: Pass domain constraints through error blocks

[Johannes Doerfert via llvm-commits]

The problem was that we used the domain context (param set of the
domain) to simplify the assumptions and that it already contained the
assumptions for error blocks. As we now do not add any conditions
relevant only to error blocks to the domain the flag should not be
necessary any more.

On 11/11, Tobias Grosser wrote:
> On 11/11/2015 06:36 PM, Johannes Doerfert wrote:
> >Did you check if we still need the HasErrorBlock flag? I was under the
> >impression we do not because we do not use error block conditions in the
> >domain anymore. Thus, there should be no harm in simplifying the
> >assumptions with the domain again, even if there are error blocks in the
> >SCoP.
> 
> I looked at it earlier, but could not convince myself this flag is not
> needed any more. The comment says it prevents a simplification that is
> problematic in case certain basic blocks have been removed from the scop.
> Even though we propagate the domains through error blocks, we
> still do not generate ScopStmts for them. So the problem described in
> the comment seems to remain.
> 
> Best,
> Tobias
> 

-- 

Johannes Doerfert
Researcher / PhD Student

Compiler Design Lab (Prof. Hack)
Saarland University, Computer Science
Building E1.3, Room 4.31

Tel. +49 (0)681 302-57521 : doerfert at cs.uni-saarland.de
Fax. +49 (0)681 302-3065  : http://www.cdl.uni-saarland.de/people/doerfert
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151111/be686d5e/attachment.sig>