[compiler-rt] r252683 - Sancov in C++.

[Mike Aizatsky via llvm-commits]

Thanks for taking care of this. I wasn't aware that we build compiler-rt
separately. I'll resubmit the tool into llvm/tools/sancov.

On Wed, Nov 11, 2015 at 7:58 AM Diego Novillo <dnovillo at google.com> wrote:

> I've reverted this commit in r252744 to restore our builds.
>
>
> Diego.
> On Wed, Nov 11, 2015 at 10:13 AM, Chandler Carruth via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
>
>> On Tue, Nov 10, 2015 at 11:17 PM Alexey Samsonov via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Sorry for joining that late. I'm pretty sure compiler-rt is the wrong
>>> place for this tool, and we should move it under llvm/tools/ instead
>>> (together with llvm-symbolizer, llvm-cxxdump etc.):
>>>
>>
>> +1, please fix this ASAP, its breaking how we build and use compiler-rt.
>> We may need to revert this temporarily to make progress.
>>
>>
>>>
>>> * we don't include any LLVM headers in compiler-rt libraries (there will
>>> be some discussion to allow that for profile library, but there are
>>> different reasons).
>>> actually, we even support standalone build of compiler-rt repository,
>>> and there is no guarantee that LLVM source code (or CMake rules
>>> definitions) will be available.
>>> * sancov is a parser/transformer of specific binary format, not a
>>> compiler runtime (or resource file that should accompany it).
>>> * sancov uses LLVM libs, so we want as much LLVM developers as possible
>>> to be able to build/test it. Currently it will never be compiled if
>>> compiler-rt is missing, or sanitizers are not supported on host.
>>> * LLVM test-suite is more suitable for writing lit tests for sancov: it
>>> should be tested on a host architecture like every other tool.
>>>
>>
>> +100
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151111/953ad0df/attachment.html>