[PATCH] D14228: [FunctionAttrs] Identify norecurse functions

[James Molloy via llvm-commits]

jmolloy added a comment.

Hi Manman,

Chatting with Mehdi on IRC, I elaborated a bit on what that first check is doing; it's just an optimization. It's the same check as in the top-down-only function, it just runs a bit earlier so has the potential to catch more cases, earlier, opening up more opportunities for the other bottom-up checks.

Mehdi rightly stated that it only affects functions that were marked norecurse before FunctionAttrs ran. He also mentioned that the checks should be factored together, which I agree with (changing the first check in bottom-up to just call addNoRecurseAttrsTopDownOnly().

James


Repository:
  rL LLVM

http://reviews.llvm.org/D14228