[PATCH] D14412: [Polly][WIP] Emit remarks for taken assumptions

[Tobias Grosser via llvm-commits]

grosser added a comment.

Hi Johannes,

this looks generally good. Please make sure to add good test cases.

Best,
Tobias


================
Comment at: include/polly/ScopInfo.h:77
@@ +76,3 @@
+  INVARIANTLOAD,
+  DELINIARIZATION,
+};
----------------
DELINEARIZATION

================
Comment at: lib/Analysis/ScopInfo.cpp:102
@@ -94,1 +101,3 @@
+                     cl::cat(PollyCategory));
+
 //===----------------------------------------------------------------------===//
----------------
The option name made me first think that this is actually about taking assumptions or not, but indeed this only affects the reporting. This caused confusion. As this is anyhow can be controlled byt the -Rpass, -pass-remarks flags I wonder if we should not just drop this option.

================
Comment at: lib/Analysis/ScopInfo.cpp:2357
@@ +2356,3 @@
+          (*II)->getAccessInstruction()->getDebugLoc(),
+          "Possible aliasing pointer, use restrict keyword.");
+
----------------
This seems to be an independent change and could be committed by itself.

================
Comment at: lib/Analysis/ScopInfo.cpp:2868
@@ +2867,3 @@
+  emitOptimizationRemarkAnalysis(F.getContext(), DEBUG_TYPE, F, Loc, Msg);
+}
+
----------------
We might want to add this logic to ScopDetectionDiagnostic.cpp

================
Comment at: lib/Analysis/ScopInfo.cpp:3836
@@ -3770,1 +3835,3 @@
+                                 "SCoP ends here.");
+
   DEBUG(scop->print(dbgs()));
----------------
These changes seem unrelated and also seem to duplicate the logic in emitValidRemarks(). 


http://reviews.llvm.org/D14412