[PATCH] D14525: Remove unused local variable

[Andy Ayers via llvm-commits]

I built both with VS2015 and with Clang3.7... not with -Werror on, but I don’t recall seeing warnings either.

I probably just missed them somehow.

From: David Blaikie [mailto:dblaikie at gmail.com]
Sent: Monday, November 9, 2015 7:39 PM
To: Andy Ayers <andya at microsoft.com>
Cc: reviews+D14525+public+44dfeb4c191f02ac at reviews.llvm.org; llvm-commits <llvm-commits at lists.llvm.org>
Subject: Re: [PATCH] D14525: Remove unused local variable



On Mon, Nov 9, 2015 at 7:37 PM, Andy Ayers <andya at microsoft.com<mailto:andya at microsoft.com>> wrote:
Or just not cause the problem in the first place... not sure why the builds I did didn’t flag this.

What compiler are you building with? Are you building with -Werror enabled?


From: David Blaikie [mailto:dblaikie at gmail.com<mailto:dblaikie at gmail.com>]
Sent: Monday, November 9, 2015 7:20 PM
To: reviews+D14525+public+44dfeb4c191f02ac at reviews.llvm.org<mailto:reviews%2BD14525%2Bpublic%2B44dfeb4c191f02ac at reviews.llvm.org>; Andy Ayers <andya at microsoft.com<mailto:andya at microsoft.com>>
Cc: llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>>
Subject: Re: [PATCH] D14525: Remove unused local variable

committed something like this along with another fix in 252580

Feel free to just commit stuff like this without review in the future, if you have commit access - it's simple enough.

On Mon, Nov 9, 2015 at 7:13 PM, Andy Ayers via llvm-commits <llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>> wrote:
AndyAyers created this revision.
AndyAyers added a subscriber: llvm-commits.
AndyAyers set the repository for this revision to rL LLVM.

Fix warning caused by unused local variable.  NFC.


Repository:
  rL LLVM

http://reviews.llvm.org/D14525<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2freviews.llvm.org%2fD14525&data=01%7c01%7candya%40microsoft.com%7c6c35e95355f646d9110708d2e97dcd1b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=9a1O9tqqDJ0%2bnD9hkUoLvhpU9lgzu35tyd13Jn4vOG4%3d>

Files:
  lib/Target/X86/X86FrameLowering.cpp

Index: lib/Target/X86/X86FrameLowering.cpp
===================================================================
--- lib/Target/X86/X86FrameLowering.cpp
+++ lib/Target/X86/X86FrameLowering.cpp
@@ -749,8 +749,8 @@

   assert(InProlog && "ChkStkStub called outside prolog!");

-  MachineInstrBuilder CI = BuildMI(MBB, MBBI, DL, TII.get(X86::CALLpcrel32))
-                               .addExternalSymbol("__chkstk_stub");
+  BuildMI(MBB, MBBI, DL, TII.get(X86::CALLpcrel32))
+      .addExternalSymbol("__chkstk_stub");

   return MBBI;
 }



_______________________________________________
llvm-commits mailing list
llvm-commits at lists.llvm.org<mailto:llvm-commits at lists.llvm.org>
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2flists.llvm.org%2fcgi-bin%2fmailman%2flistinfo%2fllvm-commits&data=01%7c01%7candya%40microsoft.com%7c6c35e95355f646d9110708d2e97dcd1b%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=%2fW0XZxv5iWvganxKgsXulMKSZbgHwUMiVLxyECFH7Gw%3d>


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151110/66be132c/attachment.html>