[PATCH] D14518: [ARM] Handle t2ADDri in ARMAsmPrinter::EmitUnwindingInstruction

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 15:52:59 PST 2015


t.p.northover added a comment.

Hi Akira,

The code change looks fine, but the test is quite a bit more complicated than it needs to be. The key points triggering this error are:

- A frame pointer is required and is r11 (so that t2ADD is used)
- sp != fp

I believe this is a reasonably minimal example (using the normal call to ensure the FP isn't eliminated and the asm to make sure at least one callee-saved register is used):

  define void @foo1() {
    call void asm sideeffect "", "~{r4}"()
    call void @foo2()
    ret void
  }
  declare void @foo2()


http://reviews.llvm.org/D14518





More information about the llvm-commits mailing list