[PATCH] D14520: llvm-lto: trivial spelling changes to distinguish custom diagnostic handler and default diagnostic handler

Yunzhong Gao via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 15:50:37 PST 2015


ygao created this revision.
ygao added subscribers: joker.eph, dexonsmith, pcc, rafael, llvm-commits.

Make a trivial spelling change (capitalization) to the llvm-lto tester to distinguish when a custom diagnostic handler is installed (llvm-lto -use-diagnostic-handler) and when a default handler is being used. This is split off from D14313.

http://reviews.llvm.org/D14520

Files:
  test/LTO/X86/diagnostic-handler-remarks.ll
  tools/llvm-lto/llvm-lto.cpp

Index: tools/llvm-lto/llvm-lto.cpp
===================================================================
--- tools/llvm-lto/llvm-lto.cpp
+++ tools/llvm-lto/llvm-lto.cpp
@@ -103,16 +103,16 @@
                               const char *Msg, void *) {
   switch (Severity) {
   case LTO_DS_NOTE:
-    errs() << "note: ";
+    errs() << "Note: ";
     break;
   case LTO_DS_REMARK:
-    errs() << "remark: ";
+    errs() << "Remark: ";
     break;
   case LTO_DS_ERROR:
-    errs() << "error: ";
+    errs() << "Error: ";
     break;
   case LTO_DS_WARNING:
-    errs() << "warning: ";
+    errs() << "Warning: ";
     break;
   }
   errs() << Msg << "\n";
Index: test/LTO/X86/diagnostic-handler-remarks.ll
===================================================================
--- test/LTO/X86/diagnostic-handler-remarks.ll
+++ test/LTO/X86/diagnostic-handler-remarks.ll
@@ -9,7 +9,7 @@
 
 ; RUN: llvm-lto -pass-remarks=inline -use-diagnostic-handler \
 ; RUN:         -exported-symbol _main -o %t.o %t.bc 2>&1 | \
-; RUN:     FileCheck %s -allow-empty -check-prefix=REMARKS
+; RUN:     FileCheck %s -allow-empty -check-prefix=REMARKS_DH
 ; RUN: llvm-nm %t.o | FileCheck %s -check-prefix NM
 
 ; Confirm that -pass-remarks are not printed by default.
@@ -24,7 +24,9 @@
 ; RUN: llvm-nm %t.o | FileCheck %s -check-prefix NM
 
 ; REMARKS: remark:
+; REMARKS_DH: Remark:
 ; CHECK-NOT: remark:
+; CHECK-NOT: Remark:
 ; NM-NOT: foo
 ; NM: main
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14520.39763.patch
Type: text/x-patch
Size: 1432 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151109/8aa35857/attachment.bin>


More information about the llvm-commits mailing list