[PATCH] D14313: Add a libLTO diagnostic handler that supports lto_get_error_message API

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 13:21:55 PST 2015


> On 2015-Nov-09, at 12:54, Mehdi AMINI <mehdi.amini at apple.com> wrote:
> 
> joker.eph added inline comments.
> 
> ================
> Comment at: tools/llvm-lto/llvm-lto.cpp:115
> @@ -114,3 +114,3 @@
>   case LTO_DS_WARNING:
> -    errs() << "warning: ";
> +    errs() << "Warning: ";
>     break;
> ----------------
> These changes are unrelated to the rest of this patch right? Please split if it is the case.
> 
> 
> http://reviews.llvm.org/D14313

Actually, I don't understand why it's being capitalized.  Don't we usually use "error:" and "warning:" for clang diagnostics?  Wouldn't we want to be consistent in LTO, at least for the defaults?


More information about the llvm-commits mailing list