[PATCH] D14511: Emit discriminator for inlined callsites.

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 13:15:46 PST 2015


dblaikie added inline comments.

================
Comment at: test/DebugInfo/Generic/discriminator.ll:11
@@ +10,3 @@
+;
+;static void bar() { abc(); }
+;static void baz() { xyz(); }
----------------
perhaps write these with __attribute__((always_inline)) so you can build the example without running the full optimization pipeline & still get the desired code.

Do you need two different inline functions or two different destination functions? (maybe it makes the example simpler/more obvious, which is fair - but it could just be two of the same)

================
Comment at: test/DebugInfo/Generic/discriminator.ll:14
@@ +13,3 @@
+;
+;void foo(int i) {
+;  bar(); baz();
----------------
I assume this function doesn't need a parameter


http://reviews.llvm.org/D14511





More information about the llvm-commits mailing list