[PATCH] D13956: [x86] try harder to match bitwise 'or' into an LEA

[Quentin Colombet via llvm-commits]

qcolombet accepted this revision.
qcolombet added a comment.

Hi Sanjay,

LGTM.

One comment though, I believe the problem with isBaseWithConstantOffset is not the use of MaskedValueIsZero, but the fact we expect a constant to feed that mask. I wonder if it could be of general use to refactor the logic so that it is available everywhere, like isOrSameAsAdd or something.

Cheers,
-Quentin


http://reviews.llvm.org/D13956