[PATCH] D12781: PGO IR-level instrumentation infrastructure

[Sean Silva via llvm-commits]

silvas added inline comments.

================
Comment at: lib/Transforms/Instrumentation/PGOIRInstr.cpp:167
@@ +166,3 @@
+// This class implements the CFG edges. Note the CFG can be a multi-graph.
+template <class Edge, class BBInfo> class PGOIRInstrumentationFunc {
+private:
----------------
davidxl wrote:
> silvas wrote:
> > Why "IR"? Are you planning to generalize this to Machine? For now just leave off "IR" (here and elsewhere).
> There was an earlier suggestion to change 'Late' in  PGOLateInstrumentation to 'IR'.  To add more to the bikeshed, I suggest change the class name to
> 
> class FuncPGOInstrumentation {
> };
The suggestion to use "IR" instead of "Late" is just for informal discussion when needed to differentiate from what we currently have in clang. For comments in code or naming variables, all code in lib/Transforms is inherently at IR level so it is redundant. For example, we do not have a "SROAIR" pass or "InstCombineIR" pass etc. (grep for "IR" in lib/Transforms to see typical usage; it is almost never used)


http://reviews.llvm.org/D12781