[PATCH] D13829: [IR] Move optional data in llvm::Function into a hungoff uselist

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 9 10:59:49 PST 2015


sanjoy added a comment.

I'm not familiar with all of the pieces you're touching here, but apart from the minor nit mentioned inline I don't have much to add.


================
Comment at: lib/IR/Function.cpp:330
@@ +329,3 @@
+  if (getNumOperands()) {
+    Op<0>().set(nullptr);
+    Op<1>().set(nullptr);
----------------
Can you use `dropAllReferences` here?


http://reviews.llvm.org/D13829





More information about the llvm-commits mailing list