[PATCH] D14359: [elf2] Add support for R_X86_64_TLSLD.

[Rafael Espíndola via llvm-commits]

On 6 November 2015 at 18:43, Michael Spencer <bigcheesegs at gmail.com> wrote:
> Bigcheese added inline comments.
>
> ================
> Comment at: ELF/OutputSections.cpp:83
> @@ -82,1 +82,3 @@
>
> +template <class ELFT> uint32_t GotSection<ELFT>::addLocalModuleTlsIndex() {
> +  Entries.push_back(nullptr);
> ----------------
> rafael wrote:
>> Will this also be used for global tls? Change the name if so.
> No. Global Dynamic symbols can be handled by addEntry already. Just needs to check the symbol type.

Not sure I follow, with a tlsgd we have to create two entries, just
like now, but one of them gets a R_X86_64_DTPOFF64.

In any case, please upload a rebased patch with the test changes (and
the rename if appropriate).

Cheers,
Rafael