[PATCH] D12577: std::string asan annotations

Mike Aizatsky via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 16:43:11 PST 2015


aizatsky added a comment.

ptal


================
Comment at: include/string:3068
@@ -2908,1 +3067,3 @@
     {
+        if (__new_sz > __sz) {
+          __annotate_grow(__sz, __new_sz);
----------------
kcc wrote:
> seems to be a common pattern. Hide it inside __annotate_*? 
It is not. Sometimes it is >, sometimes it is <, sometimes it is unconditionable.


http://reviews.llvm.org/D12577





More information about the llvm-commits mailing list