[PATCH] D14464: Add discriminators for call instructions that are from the same line and same basic block.

Dehao Chen via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 16:40:21 PST 2015


danielcdh added a comment.

In http://reviews.llvm.org/D14464#284194, @probinson wrote:

> Wouldn't you distinguish these by column number?  Discriminator is intended to be for paths that can't be distinguished solely by source location.


The main user of discriminator is AutoFDO, which does not use column number to index the profile for many reasons. So discriminator is used here to distinguish control flows that reside within the same line.


http://reviews.llvm.org/D14464





More information about the llvm-commits mailing list