[PATCH] D14401: [PGO] Make indexed value profile data more compact and add structural definitions for the data format

[Xinliang David Li via llvm-commits]

On Fri, Nov 6, 2015 at 3:01 PM, Vedant Kumar <vsk at apple.com> wrote:

> vsk added a comment.
>
> It'd be nice to have blob testing done before a major release, but that
> sounds like a discussion for llvm-dev. Lgtm with a tiny nit.
>

Or make it clear that backward compatibility of value profile format is not
guaranteed in the release note (at least for a couple of initial releases)
:)


>
>
> ================
> Comment at: include/llvm/ProfileData/InstrProf.h:424
> @@ +423,3 @@
> +  // Since NumValueSites is greater than zero, there is at least one
> +  // element inthe array.
> +  uint8_t SiteCountArray[1];
> ----------------
> nit: inthe -> in the
>

ok.

thanks,

David


>
>
> http://reviews.llvm.org/D14401
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151106/b9a65992/attachment.html>