[PATCH] D14228: [FunctionAttrs] Identify norecurse functions

Manman Ren via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 09:39:32 PST 2015


manmanren added inline comments.

================
Comment at: lib/Transforms/IPO/FunctionAttrs.cpp:1778
@@ +1777,3 @@
+  // If F is internal, has only one use and that use of F is a norecurse
+  // function, then F is also norecurse.
+  if (F->hasOneUse() && F->hasInternalLinkage())
----------------
joker.eph wrote:
> Why one use? If F has multiple callers but they are all "norecurse", shouldn't it be enough?
During bottom-up traversal, have the uses of F been visited and possibly marked as norecurse?


Repository:
  rL LLVM

http://reviews.llvm.org/D14228





More information about the llvm-commits mailing list