[PATCH] D14443: [tsan] Turn lit test deadlocks into failures (OS X)

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 6 07:57:48 PST 2015


kubabrecka created this revision.
kubabrecka added reviewers: dvyukov, samsonov, kcc, glider.
kubabrecka added subscribers: llvm-commits, zaks.anna, ismailp, jasonk, jevinskie.

Several tests currently deadlock when the lit test suite is run on OS X.  At this point, I'd like to turn them into failures so we can actually have a buildbot running the tests.

One class of deadlocks is when using fork/vfork – if something fails within the fork interceptor, an external symbolizer is spawned using fork() again and that deadlock with the original fork.  Let's disable the symbolizer in these tests (none of them actually rely on the symbolizer).

Second class of deadlocks is when having a very fast timer (ITIMER_PROF, tv_usec = 10) and spawning new threads.  Apparently, a thread receives a signal at a very early initialization stage, which deadlocks again.  I don't have a solution for this yet, so I think we should just make the test simply fail on OS X.


http://reviews.llvm.org/D14443

Files:
  test/tsan/fork_atexit.cc
  test/tsan/fork_deadlock.cc
  test/tsan/fork_multithreaded.cc
  test/tsan/fork_multithreaded3.cc
  test/tsan/signal_reset.cc
  test/tsan/signal_sync.cc
  test/tsan/signal_thread.cc
  test/tsan/vfork.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14443.39531.patch
Type: text/x-patch
Size: 4832 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151106/374c521a/attachment.bin>


More information about the llvm-commits mailing list