[llvm] r252253 - Fix bugpoint breakage on libcxx introduced by r252247

[Duncan P. N. Exon Smith via llvm-commits]

> On 2015-Nov-05, at 16:45, Keno Fischer via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: kfischer
> Date: Thu Nov  5 18:45:47 2015
> New Revision: 252253
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=252253&view=rev
> Log:
> Fix bugpoint breakage on libcxx introduced by r252247
> 
> Modified:
>    llvm/trunk/tools/bugpoint/CrashDebugger.cpp
> 
> Modified: llvm/trunk/tools/bugpoint/CrashDebugger.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/bugpoint/CrashDebugger.cpp?rev=252253&r1=252252&r2=252253&view=diff
> ==============================================================================
> --- llvm/trunk/tools/bugpoint/CrashDebugger.cpp (original)
> +++ llvm/trunk/tools/bugpoint/CrashDebugger.cpp Thu Nov  5 18:45:47 2015
> @@ -828,8 +828,8 @@ static bool DebugACrash(BugDriver &BD,
>       // contribute to the crash, bisect the operands of the remaining ones
>       std::vector<const MDNode *> NamedMDOps;
>       for (auto &NamedMD : BD.getProgram()->named_metadata())
> -        NamedMDOps.insert(NamedMDOps.end(), NamedMD.op_begin(),
> -                          NamedMD.op_end());

What was the error?  This seems strange.  Should we fix something?

> +        for (auto op : NamedMD.operands())
> +          NamedMDOps.push_back(op);

Style nitpick: it'd be clearer to specify the type here (`MDNode *`?),
and "op" should really be "Op".

>       ReduceCrashingNamedMDOps(BD, TestFn).reduceList(NamedMDOps, Error);
>     }
>   }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits