[PATCH] D12781: PGO IR-level instrumentation infrastructure

[David Majnemer via llvm-commits]

majnemer added a subscriber: majnemer.

================
Comment at: lib/Transforms/Instrumentation/PGOLateInstr.cpp:301-302
@@ +300,4 @@
+
+// Compute the CRC32 of unsigned integers.
+unsigned PGOLateInstrumentationFunc::crc32UnsignedBits(unsigned Chksum,
+                                                       unsigned Value,
----------------
silvas wrote:
> Why crc32?
We already have a CRC implementation in LLVM, do we need another one?  Ours lives in <llvm/Support/JamCRC.h>

I'd imagine the one we have in-tree is considerably faster than this one...


http://reviews.llvm.org/D12781