[PATCH] D13417: [MachineCombiner] make slack optional in critical path cost calculation (PR25016)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 12:35:25 PST 2015


spatel updated this revision to Diff 39400.
spatel added a comment.

Patch updated:
If I'm understanding correctly, the logic in the last version of the patch is now acceptable, but we can improve the code/comments to make it clearer how the cost metric may differ per pattern.

Ideally, this would be contained in the enum class itself, but C++ doesn't allow that, so I've added a helper function to MachineCombiner instead.

I cleaned up the MachineCombinerPattern file in:
http://reviews.llvm.org/rL252196


http://reviews.llvm.org/D13417

Files:
  lib/CodeGen/MachineCombiner.cpp
  test/CodeGen/X86/machine-combiner.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13417.39400.patch
Type: text/x-patch
Size: 8023 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151105/07808df8/attachment.bin>


More information about the llvm-commits mailing list