[PATCH] D14387: Move comdat setup after global value body linking in ModuleLinker

Tobias Edler von Koch via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 12:02:03 PST 2015


tobiasvk added a subscriber: tobiasvk.

================
Comment at: lib/Linker/LinkModules.cpp:2007
@@ +2006,3 @@
+    copyComdat(SGA);
+  }
+
----------------
tejohnson wrote:
> joker.eph wrote:
> > Is is possible to just iterate over `ComdatsChosen`?
> I don't think that is straightforward since AFAIK there is no way to get directly from the comdat to all the global values that are in the comdat.
Purely stylistic.. omit braces on the single-statement for loops. Otherwise, makes sense!


http://reviews.llvm.org/D14387





More information about the llvm-commits mailing list