[PATCH] D14387: Move comdat setup after global value body linking in ModuleLinker

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 11:42:28 PST 2015


tejohnson added inline comments.

================
Comment at: lib/Linker/LinkModules.cpp:2007
@@ +2006,3 @@
+    copyComdat(SGA);
+  }
+
----------------
joker.eph wrote:
> Is is possible to just iterate over `ComdatsChosen`?
I don't think that is straightforward since AFAIK there is no way to get directly from the comdat to all the global values that are in the comdat.


http://reviews.llvm.org/D14387





More information about the llvm-commits mailing list