[PATCH] D14231: [Support] Use GetTempDir to get the temporary dir path on Windows.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 5 07:48:57 PST 2015


oops.

Sorry about that.

We should probably add a test with long env var.

On 5 November 2015 at 10:46, Aaron Ballman <aaron.ballman at gmail.com> wrote:
> aaron.ballman requested changes to this revision.
> aaron.ballman added a comment.
> This revision now requires changes to proceed.
>
> GetTempPath is unfortunately a broken API.
>
> http://blogs.msdn.com/b/larryosterman/archive/2010/10/19/because-if-you-do_2c00_-stuff-doesn_2700_t-work-the-way-you-intended_2e00_.aspx
>
> Unless this has been fixed in Windows 7 (which I don't know the answer to), I would be hesitant to switch to that API.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D14231
>
>
>


More information about the llvm-commits mailing list