[PATCH] D14312: [LLVM] Fix some Clang-tidy modernize warnings, other minor fixes

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 13:28:05 PST 2015


hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm


================
Comment at: include/llvm-c/Core.h:817
@@ -818,2 +816,3 @@
 LLVMTypeRef LLVMInt64TypeInContext(LLVMContextRef C);
+LLVMTypeRef LLVMInt128TypeInContext(LLVMContextRef C);
 LLVMTypeRef LLVMIntTypeInContext(LLVMContextRef C, unsigned NumBits);
----------------
This is exposing new functionality in the C API, but I suppose it's OK.

================
Comment at: lib/Support/TimeValue.cpp:27
@@ -25,3 +26,3 @@
 void
-TimeValue::normalize( void ) {
+TimeValue::normalize() {
   if ( nanos_ >= NANOSECONDS_PER_SECOND ) {
----------------
should we join this with the previous line while here?

================
Comment at: lib/Transforms/Scalar/MergedLoadStoreMotion.cpp:111
@@ -110,3 +110,3 @@
   static char ID; // Pass identification, replacement for typeid
-  explicit MergedLoadStoreMotion(void)
+  explicit MergedLoadStoreMotion()
       : FunctionPass(ID), MD(nullptr), MagicCompileTimeControl(250) {
----------------
might as well, drop the explicit I suppose


Repository:
  rL LLVM

http://reviews.llvm.org/D14312





More information about the llvm-commits mailing list