[PATCH] D14305: [IR] Add a `data_operand` abstraction

[Philip Reames via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/previous minor comments applied.


================
Comment at: include/llvm/IR/InstrTypes.h:1130
@@ +1129,3 @@
+  bool operandsHaveAttr(Attribute::AttrKind A) const {
+    // Conservative answer:  no operands have any attributes.
+    return false;
----------------
sanjoy wrote:
> reames wrote:
> > Given this, I'm somewhat questioning the need for this entire change.  How horrible would it be to just make each place which tries to visit call site arguments have a check for whether the call has any bundle and then bail?  This sorta feels like unnecessarily generality.  
> We will soon have `nocapture` and `readonly` for values in the `"deopt"` operand bundle here.
Ah.  Duh.  :)


http://reviews.llvm.org/D14305