[PATCH] D14328: [tsan] Handle libdispatch worker threads on OS X

Kuba Brecka via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 05:08:55 PST 2015


kubabrecka updated this revision to Diff 39192.
kubabrecka added a comment.

Updating patch.

> I guess the order will actually be reversed, because user will install the hook after tsan runtime. So if user hook calls any intercepted functions or is instrumented, this still will crash.  We can solve it later.


The API is actually private and should not be used by user code (although the header files and API declarations are publicly available on opensource.apple.com).  The only user of this hook that I know of is Xcode's debugger, which actually calls the previous function at the beginning of its hook, so we're fine here.  Anyway, if this becomes an issue later, I'll take a look at it.


http://reviews.llvm.org/D14328

Files:
  lib/tsan/rtl/tsan_clock.cc
  lib/tsan/rtl/tsan_defs.h
  lib/tsan/rtl/tsan_interceptors.cc
  lib/tsan/rtl/tsan_platform.h
  lib/tsan/rtl/tsan_platform_mac.cc
  lib/tsan/rtl/tsan_rtl_thread.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14328.39192.patch
Type: text/x-patch
Size: 5680 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151104/11b2bec4/attachment.bin>


More information about the llvm-commits mailing list