[PATCH] D14187: [compiler-rt][aarch64] New tests for 128-bit floating-point builtins, fixes of tests and __fixuint

Sergey Dmitrouk via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 4 04:13:21 PST 2015


sdmitrouk marked an inline comment as done.
sdmitrouk added a comment.

Somehow missed the inline comment.


================
Comment at: test/builtins/Unit/fixunstfti_test.c:89
@@ +88,3 @@
+    if (test__fixunstfti(0x1.FFFFFEp+126, make_ti(0x7fffff8000000000LL, 0x0)))
+        return 1;
+    if (test__fixunstfti(0x1.FFFFFEp+127, make_ti(0xffffff0000000000LL, 0x0)))
----------------
Actually it should be `(0xffffffffffffffffLL, 0xffffffffffffffffLL)` because input is larger than 2^128. `__fixuint` seems to have off by one error when checking for too large exponent (used `>` instead of `>=`), updated revision to address this. Thanks!


Repository:
  rL LLVM

http://reviews.llvm.org/D14187





More information about the llvm-commits mailing list