[PATCH] D14305: [IR] Add a `data_operand` abstraction

[Sanjoy Das via llvm-commits]

sanjoy added inline comments.

================
Comment at: include/llvm/IR/Instructions.h:1614
@@ +1613,3 @@
+  /// To check an attribute on the return value, set \p i to 0.  To check an
+  /// attribute on the operand at index k (call argument, or bundle operand),
+  /// set \p i to k + 1.
----------------
reames wrote:
> I get what you're going for here, but the wording is really confusing.  *Which* index?  
> 
> For arguments, I'd just say: ZeroBasedArgNo + 1
> For bundle operands, how do you even handle this?  Are you essentially extending ArgNo?  It's not the underlying operand number right?
I've added a clarifying comment.


http://reviews.llvm.org/D14305