[PATCH] D14301: [elf2] Implement R_X86_64_TPOFF32.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 14:19:15 PST 2015


ruiu added inline comments.

================
Comment at: ELF/OutputSections.h:374
@@ -373,1 +373,3 @@
+  static
+      typename llvm::object::ELFFile<ELFT>::uintX_t ThreadInitializationImageVA;
 };
----------------
Bigcheese wrote:
> ruiu wrote:
> > This name is too long. How about TlsTemplateVA?
> Initialization image is the term of art for this. How about TlsInitImageVA?
I think I still kind of like template (mainly because it's just one word), and that's used in Ulrich Drepper's document too (http://www.akkadia.org/drepper/tls.pdf)


http://reviews.llvm.org/D14301





More information about the llvm-commits mailing list